Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move headers into include/cugraph dir #1582

Merged

Conversation

trxcllnt
Copy link
Collaborator

@trxcllnt trxcllnt commented May 7, 2021

This PR moves the headers in cpp/include into cpp/include/cugraph and updates C++ and Cython #include directives.

This change makes it easier for other libs to avoid naming conflicts with cuGraph public headers when linking libcugraph.so.

closes #1491

@trxcllnt trxcllnt requested review from a team as code owners May 7, 2021 20:22
@trxcllnt trxcllnt changed the title Move headers into cugraph dir Move headers into include/cugraph dir May 7, 2021
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some copyright dates causing failures.

Thanks for these edits!

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #1582 (383f649) into branch-0.20 (250f2c8) will decrease coverage by 0.58%.
The diff coverage is 66.09%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #1582      +/-   ##
===============================================
- Coverage        61.04%   60.45%   -0.59%     
===============================================
  Files               73       77       +4     
  Lines             3219     3391     +172     
===============================================
+ Hits              1965     2050      +85     
- Misses            1254     1341      +87     
Impacted Files Coverage Δ
python/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/components/connectivity.py 95.65% <ø> (ø)
python/cugraph/dask/centrality/katz_centrality.py 29.16% <ø> (ø)
python/cugraph/dask/link_analysis/pagerank.py 21.87% <0.00%> (ø)
python/cugraph/dask/traversal/bfs.py 25.00% <0.00%> (-2.59%) ⬇️
...ure/graph_implementation/simpleDistributedGraph.py 22.72% <22.72%> (ø)
python/cugraph/linear_assignment/lap.py 71.42% <50.00%> (-10.39%) ⬇️
python/cugraph/structure/number_map.py 66.79% <57.14%> (+2.97%) ⬆️
python/cugraph/structure/symmetrize.py 68.62% <60.00%> (-4.71%) ⬇️
...raph/structure/graph_implementation/simpleGraph.py 73.98% <73.98%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 924f678...383f649. Read the comment docs.

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 11, 2021
@BradReesWork BradReesWork added this to the 21.06 milestone May 11, 2021
@BradReesWork BradReesWork added breaking Breaking change and removed non-breaking Non-breaking change labels May 11, 2021
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the work here!

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4905a35 into rapidsai:branch-0.20 May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Refactor C++ include directory
6 participants