-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move headers into include/cugraph
dir
#1582
Move headers into include/cugraph
dir
#1582
Conversation
include/cugraph
dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some copyright dates causing failures.
Thanks for these edits!
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #1582 +/- ##
===============================================
- Coverage 61.04% 60.45% -0.59%
===============================================
Files 73 77 +4
Lines 3219 3391 +172
===============================================
+ Hits 1965 2050 +85
- Misses 1254 1341 +87
Continue to review full report at Codecov.
|
…ve-headers-into-cugraph-dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all the work here!
@gpucibot merge |
This PR moves the headers in
cpp/include
intocpp/include/cugraph
and updates C++ and Cython#include
directives.This change makes it easier for other libs to avoid naming conflicts with cuGraph public headers when linking
libcugraph.so
.closes #1491