Fix multi-GPU hang on graph generation #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts integrated to raft)
…rs as a workaround for a NCCL bug
seunghwak
added
2 - In Progress
DO NOT MERGE
|
@rlratzel There is a one more bug I am tracking but you can run this on other machines and see how this works (to see the current unresolved issue is DGX1 specific or not). |
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #1572 +/- ##
==============================================
Coverage ? 59.98%
==============================================
Files ? 77
Lines ? 3369
Branches ? 0
==============================================
Hits ? 2021
Misses ? 1348
Partials ? 0 Continue to review full report at Codecov.
|
seunghwak
added
3 - Ready for Review
non-breaking
rlratzel
approved these changes
May 4, 2021
aschaffer
approved these changes
May 5, 2021
BradReesWork
approved these changes
May 6, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
## Description This PR cleans up some `#include`s for Thrust. This is meant to help ease the transition to Thrust 1.17 when that is updated in rapids-cmake. ## Context I opened a PR rapidsai/cudf#10489 that updates cuDF to Thrust 1.16. Notably, version 1.16 of Thrust reduced the number of internal header inclusions: > [#1572](NVIDIA/thrust#1572) Removed several unnecessary header includes. Downstream projects may need to update their includes if they were relying on this behavior. I spoke with @robertmaynard and he recommended making similar changes to clean up includes ("include what we use," in essence) to make sure we have compatibility with future versions of Thrust across all RAPIDS libraries. This changeset also makes it more obvious where cugraph depends on `thrust/detail` headers. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Brad Rees (https://github.com/BradReesWork) - Seunghwa Kang (https://github.com/seunghwak) URL: #2310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bug fixes for multi-GPU graph creation.