Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized docs and environment files #1537

Merged
merged 7 commits into from
Apr 16, 2021
Merged

Reorganized docs and environment files #1537

merged 7 commits into from
Apr 16, 2021

Conversation

BradReesWork
Copy link
Member

  • reorganized docs so that information is under ./docs/cugraph that better matches the rest of rapids
  • Updated yml files
  • removed unneeded packages in the yml files
  • drop old notebook
  • marked FA2 notebook as skip

@BradReesWork BradReesWork requested review from a team as code owners April 15, 2021 17:07
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@BradReesWork BradReesWork added this to the 0.20 milestone Apr 15, 2021
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 15, 2021
@BradReesWork BradReesWork self-assigned this Apr 15, 2021
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes.

Quick comment though. Since we'll be deprecating 10.x in the 0.19 release (link), you could consider removing the 10.x yaml files from the 0.20 branch altogether.

@BradReesWork
Copy link
Member Author

Approving ops-codeowner file changes.

Quick comment though. Since we'll be deprecating 10.x in the 0.19 release (link), you could consider removing the 10.x yaml files from the 0.20 branch altogether.

I was going to wait until 0.21 to drop those - just in cases we need to revert :-)

@BradReesWork
Copy link
Member Author

@gpucibot merge

@ajschmidt8
Copy link
Member

rerun tests

Copy link
Contributor

@Iroy30 Iroy30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rapids-bot rapids-bot bot merged commit aa04421 into rapidsai:branch-0.20 Apr 16, 2021
rapids-bot bot pushed a commit that referenced this pull request Apr 22, 2021
This PR updates the doc build paths in CI to reflect the changes in #1537.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Dillon Cullinan (https://github.com/dillon-cullinan)

URL: #1554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants