Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams infra + support in egonet #1435

Merged
merged 17 commits into from
Mar 5, 2021
Merged

Conversation

afender
Copy link
Member

@afender afender commented Mar 3, 2021

  • Stream synchronization behavior: switched to per-thread default stream instead of the legacy default stream
  • Update raft tag
  • EgoNet upgrade to use uvector instead of device_vector
  • EgoNet upgrade to execute on a different stream for each seed
  • Perf analysis timers/app for EgoNet

Concurrency is limited by the number of available blocks on the device. Thrust-based codes may request a lot of blocks without a way to control this. In practice, smaller graphs leverage concurrency better than larger ones where tasks may end up waiting for available resources.

We may wait on #1407 before reconciling and merging this
Close #957

@afender afender added 2 - In Progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 3, 2021
@afender afender added this to the 0.19 milestone Mar 3, 2021
@afender afender requested review from Iroy30 and seunghwak March 3, 2021 00:16
@afender afender self-assigned this Mar 3, 2021
@afender afender requested review from a team as code owners March 3, 2021 00:16
@afender afender changed the title Streams infra and support in egonet Streams infra + support in egonet Mar 3, 2021
@codecov-io
Copy link

codecov-io commented Mar 3, 2021

Codecov Report

Merging #1435 (c47818d) into branch-0.19 (369beee) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #1435      +/-   ##
===============================================
+ Coverage        60.72%   60.75%   +0.02%     
===============================================
  Files               70       70              
  Lines             3132     3134       +2     
===============================================
+ Hits              1902     1904       +2     
  Misses            1230     1230              
Impacted Files Coverage Δ
python/cugraph/utilities/utils.py 71.65% <0.00%> (ø)
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f2f5b...c47818d. Read the comment docs.

Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for few small complaints.

cpp/src/community/egonet.cu Outdated Show resolved Hide resolved
cpp/src/community/egonet.cu Outdated Show resolved Hide resolved
cpp/src/community/egonet.cu Outdated Show resolved Hide resolved
cpp/tests/community/egonet_test.cu Outdated Show resolved Hide resolved
@BradReesWork
Copy link
Member

rerun tests

@afender afender requested a review from seunghwak March 3, 2021 17:48
@BradReesWork BradReesWork requested a review from aschaffer March 4, 2021 21:27
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e525040 into rapidsai:branch-0.19 Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Streams support in cugraph
5 participants