-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streams infra + support in egonet #1435
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #1435 +/- ##
===============================================
+ Coverage 60.72% 60.75% +0.02%
===============================================
Files 70 70
Lines 3132 3134 +2
===============================================
+ Hits 1902 1904 +2
Misses 1230 1230
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for few small complaints.
rerun tests |
@gpucibot merge |
uvector
instead ofdevice_vector
Concurrency is limited by the number of available blocks on the device. Thrust-based codes may request a lot of blocks without a way to control this. In practice, smaller graphs leverage concurrency better than larger ones where tasks may end up waiting for available resources.
We may wait on #1407 before reconciling and merging this
Close #957