-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EgoNet #1365
Merged
Merged
EgoNet #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afender
added
feature request
New feature or request
2 - In Progress
non-breaking
Non-breaking change
labels
Jan 29, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #1365 +/- ##
===============================================
+ Coverage 60.38% 60.88% +0.50%
===============================================
Files 67 68 +1
Lines 3029 3096 +67
===============================================
+ Hits 1829 1885 +56
- Misses 1200 1211 +11
Continue to review full report at Codecov.
|
Iroy30
approved these changes
Feb 3, 2021
BradReesWork
approved these changes
Feb 4, 2021
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let the egonet graph of a node x be the subgraph that includes the neighborhood of x and all edges between them. Here is a basic description (1-hop, single seed) :
Proposed solution
Rather than doing custom one/two hops features, we propose a generic k-hops solution leveraging BFS with cutoff to identify neighbors within a given radius.
In addition to the single source version (matching what's available in Nx), we propose to handle multiple sources (seeds) at once which allows better performances.
This PR also enables a path in the experimental stack for returning multiple graphs (edge list format) from CUDA prims to python without using the legacy classes.
As future work, we want to enable concurrency for the cutoff BFS for each seed. This is dependent of #957
Close #475