Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for MNMG coarsen_graph, renumber_edgelist, relabel #1364

Merged
merged 4 commits into from
Feb 2, 2021

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Jan 29, 2021

Bug fixes for MNMG coarsen_graph, renumber_edgelist, relabel

@BradReesWork BradReesWork added this to the 0.18 milestone Jan 29, 2021
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 29, 2021
@seunghwak seunghwak changed the title [WIP][skip-ci] bug fixes in coarsen_graph,renumber_edgelist,relabel Bug fixes for MNMG coarsen_graph, renumber_edgelist, relabel Jan 29, 2021
@seunghwak
Copy link
Contributor Author

@ChuckHastings @rlratzel @aschaffer This affects you guys, so please take a look.

@seunghwak seunghwak marked this pull request as ready for review January 29, 2021 18:57
@seunghwak seunghwak requested a review from a team as a code owner January 29, 2021 18:57
@seunghwak
Copy link
Contributor Author

rerun tests.

@seunghwak seunghwak added bug Something isn't working and removed improvement Improvement / enhancement to an existing function labels Jan 29, 2021
@aschaffer
Copy link
Collaborator

aschaffer commented Jan 29, 2021

This affects you guys, so please take a look.

Unless you've changed the signatures of sort_and_shuffle_values() or renumber_edgelist() I (at least) should not be affected. It seems that you have not changed the signatures. Please correct me if I'm wrong, Thanks.

=> No changes in the API, but if you call sort_and_shuffle_values() or renumber_edgelist(), they will fail without these bug fixes. This will not affect you till you're ready for testing, but this is necessary for the test to succeed.

@codecov-io
Copy link

Codecov Report

Merging #1364 (dbf5e64) into branch-0.18 (2fb0725) will decrease coverage by 1.45%.
The diff coverage is 57.84%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #1364      +/-   ##
===============================================
- Coverage        60.38%   58.92%   -1.46%     
===============================================
  Files               67       67              
  Lines             3029     3058      +29     
===============================================
- Hits              1829     1802      -27     
- Misses            1200     1256      +56     
Impacted Files Coverage Δ
python/cugraph/centrality/__init__.py 100.00% <ø> (ø)
python/cugraph/comms/comms.py 34.52% <25.00%> (ø)
python/cugraph/dask/common/input_utils.py 23.07% <28.57%> (+1.14%) ⬆️
python/cugraph/utilities/utils.py 42.96% <35.71%> (-28.59%) ⬇️
python/cugraph/dask/common/mg_utils.py 37.50% <38.09%> (-2.50%) ⬇️
python/cugraph/community/spectral_clustering.py 72.54% <38.46%> (-11.67%) ⬇️
python/cugraph/structure/number_map.py 58.12% <50.00%> (+2.16%) ⬆️
python/cugraph/structure/graph.py 68.75% <76.47%> (+1.95%) ⬆️
python/cugraph/__init__.py 100.00% <100.00%> (ø)
...ython/cugraph/centrality/betweenness_centrality.py 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc3ae64...dbf5e64. Read the comment docs.

@afender
Copy link
Member

afender commented Feb 2, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5813559 into rapidsai:branch-0.18 Feb 2, 2021
@seunghwak seunghwak deleted the bug_mnmg_coarsen_graph branch June 24, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants