[REVIEW] BUG Move subcomms init outside of individual algorithm functions #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omms. Still have an issue with error stating comms not initialized when trying to init subcomms.
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
4 tasks
…o branch-0.16-movesubcomminit
…e_graph_container() call and using values obtained directly from handle instead.
rlratzel
changed the title
seunghwak
approved these changes
Oct 7, 2020
afender
reviewed
Oct 7, 2020
…on of get_n_workers() call, but still need FIXME for that addressed.
afender
approved these changes
Oct 7, 2020
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.16 #1196 +/- ##
==============================================
Coverage ? 57.28%
==============================================
Files ? 61
Lines ? 2500
Branches ? 0
==============================================
Hits ? 1432
Misses ? 1068
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the subcomms init outside of the individual algorithm functions and up to the function a user calls to initialize comms. This allows the same subcomm configuration to be used across algorithms and also allows users to customize the call to optimize based on GPU configuration.
Without this, subcomms will be repeatedly created/initialized for each algo call, resulting in problems.
closes #1065
(thanks to @Iroy30 for commits 71d4a0b and 79f131c)