Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace device_memory_resource* with device_async_resource_ref #4333

Closed
Tracked by #16
, #1443
...
harrism opened this issue Apr 10, 2024 · 0 comments · Fixed by #4365
Closed
Tracked by #16
, #1443
...

Replace device_memory_resource* with device_async_resource_ref #4333

harrism opened this issue Apr 10, 2024 · 0 comments · Fixed by #4365
Labels
improvement Improvement / enhancement to an existing function

Comments

@harrism
Copy link
Member

harrism commented Apr 10, 2024

Update occurences of rmm::mr::device_memory_resource* to
rmm::device_async_resource_ref in this repo. The rationale is explained
in this document.
@harrism harrism added the improvement Improvement / enhancement to an existing function label Apr 10, 2024
This was referenced Apr 23, 2024
Merged
Open
Open
rapids-bot bot pushed a commit that referenced this issue Apr 24, 2024
@harrism
Convert device_memory_resource* to device_async_resource_ref (#4365)
3393b06 
Closes #4333

For reviewers:
Many of changes are simple textual replace of `rmm::mr::device_memory_resource *` with `rmm::device_async_resource_ref`. 

However, I found that `concurrent_unordered_map` used in cuGraph is not up to date with the
latest changes from the version in libcudf, so I copied those over as well. This gets rid
of the `hash_allocator.cuh`, and uses `rmm::mr::polymorphic_allocator` instead of the custom
allocator previously used. This obviates the need to update any `device_memory_resource*` used 
in the old custom allocator.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #4365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert device_memory_resource* to device_async_resource_ref harrism/cugraph
1 participant
@harrism