Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] Accept the shuffle and drop_last arguments in the cuGraph-PyG loader #3949

Closed
Tracked by #3806
alexbarghi-nv opened this issue Oct 20, 2023 · 0 comments · Fixed by #3995
Closed
Tracked by #3806

[IMP] Accept the shuffle and drop_last arguments in the cuGraph-PyG loader #3949

alexbarghi-nv opened this issue Oct 20, 2023 · 0 comments · Fixed by #3995
Assignees
@alexbarghi-nv
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Milestone
23.12

Comments

@alexbarghi-nv
Copy link
Member

Currently, passing these arguments results in an exception. They should be handled properly, which could be returning a warning and not modifying the behavior of cuGraph.
@alexbarghi-nv alexbarghi-nv added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 20, 2023
@alexbarghi-nv alexbarghi-nv added this to the 23.12 milestone Oct 20, 2023
@alexbarghi-nv alexbarghi-nv self-assigned this Oct 20, 2023
@alexbarghi-nv alexbarghi-nv mentioned this issue Oct 20, 2023
Open
@alexbarghi-nv alexbarghi-nv mentioned this issue Nov 12, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Nov 20, 2023
@alexbarghi-nv
Support drop_last Argument in cuGraph-PyG Loader (#3995)
f3eecda 
Supports the `drop_last` argument in cuGraph-PyG for better compatibility with native PyG workflows.

Closes #3949 

Merge after #3985

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Naim (https://github.com/naimnv)

Approvers:
  - Tingyu Wang (https://github.com/tingyu66)
  - Brad Rees (https://github.com/BradReesWork)
  - Vibhu Jawa (https://github.com/VibhuJawa)

URL: #3995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbarghi-nv alexbarghi-nv

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
23.12
Development

Successfully merging a pull request may close this issue.

Support drop_last Argument in cuGraph-PyG Loader alexbarghi-nv/cugraph
1 participant
@alexbarghi-nv