Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuGraph-PyG Should Test Training in CI #3807

Closed
Tracked by #3806
alexbarghi-nv opened this issue Aug 16, 2023 · 0 comments · Fixed by #3795
Closed
Tracked by #3806

cuGraph-PyG Should Test Training in CI #3807

alexbarghi-nv opened this issue Aug 16, 2023 · 0 comments · Fixed by #3795
Assignees
@alexbarghi-nv
Labels
improvement Improvement / enhancement to an existing function
Milestone
23.10

Comments

@alexbarghi-nv
Copy link
Member

Currently, we only test compatibility with models as part of benchmarking. In order to catch issues before they appear there, we should have a basic training test that passes in output samples from cuGraph-PyG into a model. This would be mostly a smoke test; the other tests should verify that the output of cuGraph-PyG is correct, regardless.
@alexbarghi-nv alexbarghi-nv self-assigned this Aug 16, 2023
@alexbarghi-nv alexbarghi-nv added the improvement Improvement / enhancement to an existing function label Aug 16, 2023
@alexbarghi-nv alexbarghi-nv added this to the 23.10 milestone Aug 16, 2023
@alexbarghi-nv alexbarghi-nv mentioned this issue Aug 16, 2023
Open
@alexbarghi-nv alexbarghi-nv mentioned this issue Aug 30, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Sep 25, 2023
@alexbarghi-nv
cuGraph-PyG Loader Improvements (#3795)
fe17abc 
Consolidates various speed improvements tested while running performance benchmarks.  Avoids copying batch data, removes redundant data loading code, simplifies and improves de-offsetting, even though that is now being bypassed entirely for homogeneous graphs.  Removes extra host to device copy.  Properly flips the src/dst columns in the returned `HeteroData` minibatch objects, avoid exposing this to the end user.

I've confirmed this cuts the MFG time by a factor of 4.

Closes #3807

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)

Approvers:
  - Vibhu Jawa (https://github.com/VibhuJawa)
  - Don Acosta (https://github.com/acostadon)
  - Brad Rees (https://github.com/BradReesWork)

URL: #3795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbarghi-nv alexbarghi-nv

Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
23.10
Development

Successfully merging a pull request may close this issue.

cuGraph-PyG Loader Improvements alexbarghi-nv/cugraph
1 participant
@alexbarghi-nv