Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cugraph python code to use constants for various dataframe column names #2618

Open
Tracked by #3256
rlratzel opened this issue Aug 25, 2022 · 1 comment
Open
Tracked by #3256
Assignees
Labels
feature request New feature or request

Comments

@rlratzel
Copy link
Contributor

rlratzel commented Aug 25, 2022

The current cugraph python code still has many places where hardcoded column names are used, sometimes inconsistently (eg. src, dst, weight, weights, wgt).

Other column names from PropertyGraph include those for edge ID, edge type, and vertex type, and may also need to be considered.

The proposal here is to create a single python module that defines the column names as constants which can be imported and used throughout the python code.

This PR addresses a similar problem, and should be considered in the final solution.

@rlratzel rlratzel added the ? - Needs Triage Need team to review and classify label Aug 25, 2022
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants