Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] MG PageRank requires the parameter store_transposed to be set to True #2455

Closed
jnke2016 opened this issue Jul 27, 2022 · 0 comments · Fixed by #2467
Closed

[BUG] MG PageRank requires the parameter store_transposed to be set to True #2455

jnke2016 opened this issue Jul 27, 2022 · 0 comments · Fixed by #2467
Assignees
@jnke2016
Labels
bug Something isn't working
Milestone
22.08

Comments

@jnke2016
Copy link
Contributor

jnke2016 commented Jul 27, 2022 •
edited
Loading

Describe the bug
A recent change to the python cugraph-API was introduced when integrating the PLC Graph. The legacy(cython.cu)Renumbering (which sets the parameter store_transposed) now occurs at the lazy graph creation and this parameter can no longer be set at the algo's call. PageRank is currently the only algo affected by the change. A solution would be to leverage pylibcugraph PageRank which is already implemented or raise an exception if the user doesn't set the parameter at the lazy graph creation.

Steps/Code to reproduce bug
Run the MG PageRank tests
@jnke2016 jnke2016 added ? - Needs Triage Need team to review and classify bug Something isn't working labels Jul 27, 2022
@jnke2016 jnke2016 mentioned this issue Jul 28, 2022
Merged
@rlratzel rlratzel added this to the 22.08 milestone Aug 1, 2022
@rapids-bot rapids-bot bot closed this as completed in #2467 Aug 4, 2022
rapids-bot bot pushed a commit that referenced this issue Aug 4, 2022
@jnke2016
Update PageRank to leverage pylibcugraph (#2467)
cdc563f 
This PR 

1. Extends the capabilities of the `PageRank CAPI` to the `python cuGraph API`
2. Update or Add support for the parameters `personalization` `precomputed_vertex_out_weight` and `nstart` for both the SG and MG implementation

closes #2455
closes #2430

Authors:
  - Joseph Nke (https://github.com/jnke2016)
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Seunghwa Kang (https://github.com/seunghwak)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2467
@kingmesal kingmesal removed the ? - Needs Triage Need team to review and classify label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnke2016 jnke2016

Labels
bug Something isn't working
Projects
None yet
Milestone
22.08
Development

Successfully merging a pull request may close this issue.

Update PageRank to leverage pylibcugraph jnke2016/cugraph
3 participants
@rlratzel @kingmesal @jnke2016