Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] PropertyGraph.extract_subgraph() should provide options to bypass renumbering and adding edge_data #2418

Closed
rlratzel opened this issue Jul 16, 2022 · 0 comments · Fixed by #2419
Assignees
Milestone

Comments

@rlratzel
Copy link
Contributor

PropertyGraph.extract_subgraph() should provide options to bypass renumbering and adding edge_data. Some use cases benefit from the memory savings of not adding the unneeded subgraph.edge_data, and also require vertices that are not renumbered.

@rlratzel rlratzel added ? - Needs Triage Need team to review and classify python labels Jul 16, 2022
@rlratzel rlratzel added this to the 22.08 milestone Jul 16, 2022
@rlratzel rlratzel self-assigned this Jul 16, 2022
rapids-bot bot pushed a commit that referenced this issue Jul 25, 2022
…edge_data, exclude internal `_WEIGHT_` column from `edge_property_names`, added `num_vertices_with_properties` attr (#2419)

Add options to `extract_subgraph()` to bypass renumbering and adding edge_data, exclude internal `_WEIGHT_` column from `edge_property_names`.

Also added a new attribute `num_vertices_with_properties` which returns the number of vertices with properties, which is different than the number of vertices, since vertices can be added via `add_edge_data()`.  This is needed for GNN use cases which need to know how many verts have properties which can be accessed (this corresponds to the number of rows in the internal vertex prop data table).

Added unit tests to verify new `extract_subgraph()` options work, the new `num_vertices_with_properties` attribute, and `_WEIGHT_` columns names aren't included, for both SG and MG versions.

closes #2418 
closes #2410

Authors:
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Erik Welch (https://github.com/eriknw)
  - Brad Rees (https://github.com/BradReesWork)

URL: #2419
@kingmesal kingmesal removed the ? - Needs Triage Need team to review and classify label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment