Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Graph Input checking and cugraph's errors #231

Closed
afender opened this issue Apr 18, 2019 · 7 comments
Closed

[FEA] Graph Input checking and cugraph's errors #231

afender opened this issue Apr 18, 2019 · 7 comments
Assignees
Labels
feature request New feature or request
Milestone

Comments

@afender
Copy link
Member

afender commented Apr 18, 2019

Currently, a corrupted graph input can result in a random error in the analytics algorithm later on. A feature to check the input graph should be added. This function should check as many graph properties as possible without traversing the graph (which would be too costly).
This function should be called before running an analytics function and return a clear error if some graph properties are not supported.

@afender afender added feature request New feature or request ? - Needs Triage Need team to review and classify labels Apr 18, 2019
@afender afender added this to the 0.8.0 milestone Apr 18, 2019
@seunghwak
Copy link
Contributor

We may follow cudf: rapidsai/cudf#1390

They are adding

gdf_error validate(const gdf_column& column)

and we may add

gdf_error validate(const gdf_graph& graph)

@jrhemstad
Copy link
Contributor

Note that gdf_error validate(const gdf_column& column) is simply a stop-gap solution.

In the medium term, this will go away in favor of a cudf::column class that is guaranteed to be valid after construction, i.e., any error checking would happen within the constructor and an exception would be thrown if it's erroneous.

@afender afender changed the title [FEA] Graph Input checking [FEA] Graph Input checking and cugraph's errors May 1, 2019
@BradReesWork BradReesWork removed the ? - Needs Triage Need team to review and classify label May 6, 2019
@afender
Copy link
Member Author

afender commented May 30, 2019

We should also see this issue as an opportunity to :

  1. Identify the generic error handling solution for rapids (in RAPIDS core?)
  2. Go through cugraph code and make error handling consistent

Precise points where we should improve:

@seunghwak
Copy link
Contributor

seunghwak commented May 31, 2019

In addition, cuGraph's nvgraph files have their own error handling mechanisms as well.

src/nvgraph/include/util.cuh defines CUDA_CALL and THRUST_SAFE_CALL
src/nvgraph/include/nvgraph_error.hxx defines NVGRAPH_CATCHES, CHECK_CUDA, CHECK_CURAND, CHECK_CUBLAS, CHECK_CUSPARSE, CHECK_CUSOLVER, ...
src/nvgraph/nvgraph.h defines NVG_CUDA_TRY and NVG_RMM_TRY

@afender
Copy link
Member Author

afender commented Jun 19, 2019

Input check and documentation was improved in #333.
Remaining changes should be addressed as part of the long run refactoring.

@afender afender modified the milestones: 0.8.0, 0.9.0 Jun 19, 2019
@BradReesWork BradReesWork modified the milestones: 0.9.0, 0.13 Mar 6, 2020
@BradReesWork BradReesWork modified the milestones: 0.13, 0.14 Mar 19, 2020
@BradReesWork BradReesWork modified the milestones: 0.15, 0.16 Aug 20, 2020
@BradReesWork BradReesWork modified the milestones: 0.16, 0.17 Sep 22, 2020
@BradReesWork BradReesWork modified the milestones: 0.17, 0.18 Nov 23, 2020
@BradReesWork
Copy link
Member

This is related to #537

@BradReesWork BradReesWork modified the milestones: 0.18, 0.19 Jan 13, 2021
@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@github-actions github-actions bot added the stale label Feb 16, 2021
ChuckHastings pushed a commit to ChuckHastings/cugraph that referenced this issue Jun 14, 2021
Initialize `rmm::exec_policy` with `rmm::cuda_stream_view` to fix Thrust 1.12 compile errors.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai/raft#231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants