Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] migrate contents of proto to experimental and remove proto #2303

Closed
rlratzel opened this issue May 23, 2022 · 0 comments · Fixed by #2331
Closed

[FEA] migrate contents of proto to experimental and remove proto #2303

rlratzel opened this issue May 23, 2022 · 0 comments · Fixed by #2331
Assignees
@alexbarghi-nv
Labels
? - Needs Triage Need team to review and classify breaking Breaking change improvement Improvement / enhancement to an existing function
Milestone
22.08

Comments

@rlratzel
Copy link
Contributor

For consistency and possibly less confusion, we should only have one namespace for all code that's considered a prototype, an experimental change, a new thing that's subject to change, etc. We've added experimental for that, which is consistent with other projects in the RAPIDS space such as SciKit Learn and cuML, however we also have proto which originated from older cugraph versions for the same purpose.

Since experimental is consistent with cuML and others, and has some momentum with how it provides warnings and other conventions, we should migrate code out of proto (deprecate bicliques and eventually remove, move the alternate scc to experimental) and eventually remove proto completely.
@rlratzel rlratzel added ? - Needs Triage Need team to review and classify improvement Improvement / enhancement to an existing function breaking Breaking change python labels May 23, 2022
@rlratzel rlratzel added this to the 22.08 milestone May 23, 2022
@rlratzel rlratzel assigned alexbarghi-nv and unassigned jnke2016 Jun 3, 2022
@alexbarghi-nv alexbarghi-nv mentioned this issue Jun 8, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 17, 2022
@alexbarghi-nv
Fix experimental labels (#2331)
78b394c 
Resolves #2315 
Resolves #2303

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)

Approvers:
  - Joseph Nke (https://github.com/jnke2016)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbarghi-nv alexbarghi-nv

Labels
? - Needs Triage Need team to review and classify breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
22.08
Development

Successfully merging a pull request may close this issue.

Fix experimental labels alexbarghi-nv/cugraph
3 participants
@rlratzel @jnke2016 @alexbarghi-nv