Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]test_mg_hits fails with undirected graph #2240

Closed
acostadon opened this issue Apr 21, 2022 · 0 comments · Fixed by #2247
Closed

[BUG]test_mg_hits fails with undirected graph #2240

acostadon opened this issue Apr 21, 2022 · 0 comments · Fixed by #2247
Assignees
@ChuckHastings
Labels
bug Something isn't working
Milestone
22.06

Comments

@acostadon
Copy link
Contributor

Describe the bug
Using the email-Eu-core dataset, with an undirected Graph object it does not match the single gpu results
Steps/Code to reproduce bug
Run pytest with these parameters
test_dask_hits[graph_file=../datasets/email-Eu-core.csv,max_iter=50,tol=1e-06,directed=False]

Expected behavior
expect single and multiple gpu to be equal

Environment overview (please complete the following information)

  • Environment location: [Bare-metal DGX18]
  • Method of cuGraph install: [conda]
    • If method of install is [Docker], provide docker pull & docker run commands used

Additional context
cleaned_image
@acostadon acostadon added bug Something isn't working ? - Needs Triage Need team to review and classify labels Apr 21, 2022
@BradReesWork BradReesWork removed the ? - Needs Triage Need team to review and classify label Apr 25, 2022
@BradReesWork BradReesWork added this to the 22.06 milestone Apr 25, 2022
@jnke2016 jnke2016 mentioned this issue Apr 26, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue May 11, 2022
@jnke2016
Undirected graph support for MG graphs (#2247)
e906c98 
This PR allows our MG implementation to support undirected graph by symmetrizing the dataframe. This will be consistent with the SG implementation.

It also 
- replaces the deprecated `cudf` call `append` by `concat`
- update Neighborhood sampling's docstring and code to only support `int32` vertices and labels by Dylan

closes #2240
closes #2174 
closes #2264 by raising a `ValueError` and updating the docstring

Authors:
  - Joseph Nke (https://github.com/jnke2016)
  - https://github.com/betochimas

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChuckHastings ChuckHastings

Labels
bug Something isn't working
Projects
None yet
Milestone
22.06
Development

Successfully merging a pull request may close this issue.

Undirected graph support for MG graphs jnke2016/cugraph
3 participants
@BradReesWork @ChuckHastings @acostadon