Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Incorrect number of unique IP addresses reported in Renumber-2.ipynb #2178

Closed
charlesbluca opened this issue Mar 30, 2022 · 4 comments
Closed

[DOC] Incorrect number of unique IP addresses reported in Renumber-2.ipynb #2178

charlesbluca opened this issue Mar 30, 2022 · 4 comments
Assignees
@acostadon @oorliu
Labels
doc Documentation
Milestone
22.08

Comments

@charlesbluca
Copy link
Member

Report incorrect documentation

Location of incorrect documentation
https://github.com/rapidsai/cugraph/blob/branch-22.04/notebooks/structure/Renumber-2.ipynb

Describe the problems or issues found in the documentation
The notebooks concludes with "we can now see that there are only 50 unique IP addresses in the dataset", but the results seem to imply that there are actually 52?

image

Suggested fix for documentation
Update this conclusion to match the actual number of unique IP addresses
@charlesbluca charlesbluca added ? - Needs Triage Need team to review and classify doc Documentation labels Mar 30, 2022
@BradReesWork BradReesWork removed the ? - Needs Triage Need team to review and classify label Mar 30, 2022
@BradReesWork BradReesWork added this to the 22.06 milestone Mar 30, 2022
@ChuckHastings ChuckHastings reopened this Mar 31, 2022
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@BradReesWork BradReesWork modified the milestones: 22.06, 22.08 Jun 1, 2022
@oorliu
Copy link
Contributor

oorliu commented Jun 2, 2022

It looks like the correct number of unique values is, in fact, 52! This will be updated accordingly in the documentation, and there will be an extra few lines of code to verify that this is the case (using CuPy).

@oorliu oorliu mentioned this issue Jun 3, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 6, 2022
@oorliu
DOC Fix for Renumber-2.ipynb (#2335)
0dbb785 
Fixed issue #2178. 

Updated to the correct number of unique IPs. Added code to confirm cuGraph results using CuPy.

Authors:
  - Ralph Liu (https://github.com/oorliu)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: #2335
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@rlratzel
Copy link
Contributor

closed by #2335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acostadon acostadon

@oorliu oorliu

Labels
doc Documentation
Projects
None yet
Milestone
22.08
Development

No branches or pull requests
6 participants
@rlratzel @charlesbluca @BradReesWork @ChuckHastings @acostadon @oorliu