Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] MG Katz Centrality ignores nstart parameter #2025

Closed
rlratzel opened this issue Jan 20, 2022 · 2 comments · Fixed by #2276
Closed

[BUG] MG Katz Centrality ignores nstart parameter #2025

rlratzel opened this issue Jan 20, 2022 · 2 comments · Fixed by #2276
Assignees
@betochimas
Labels
bug Something isn't working
Milestone
22.06

Comments

@rlratzel
Copy link
Contributor

rlratzel commented Jan 20, 2022 •
edited
Loading

The nstart parameter, used for providing the initial guess values, is being silently ignored by the MG version of Katz. This needs to be fixed to work as described in the documentation:

    nstart : dask_cudf.Dataframe
        GPU Dataframe containing the initial guess for katz centrality

        nstart['vertex'] : dask_cudf.Series
            Contains the vertex identifiers
        nstart['values'] : dask_cudf.Series
            Contains the katz centrality values of vertices

cc @kaatish
@rlratzel rlratzel added bug Something isn't working ? - Needs Triage Need team to review and classify python labels Jan 20, 2022
@rlratzel rlratzel added this to the 22.04 milestone Jan 20, 2022
@rlratzel rlratzel self-assigned this Jan 20, 2022
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@BradReesWork BradReesWork removed ? - Needs Triage Need team to review and classify inactive-30d labels Mar 2, 2022
@BradReesWork BradReesWork assigned acostadon and unassigned rlratzel Mar 29, 2022
@BradReesWork BradReesWork modified the milestones: 22.04, 22.06 Mar 29, 2022
@betochimas betochimas mentioned this issue May 17, 2022
Merged
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@rapids-bot rapids-bot bot closed this as completed in #2276 Jun 1, 2022
rapids-bot bot pushed a commit that referenced this issue Jun 1, 2022
@betochimas
Refactored SG hits and MG katz_centrality (#2276)
83f9f0c 
This PR:
1. Refactors SG `hits` with the updated pylibcugraph implementation
2. Refactors MG `katz_centrality` with the updated pylibcugraph implementation, adding support for multiple arguments 
3. Improves support within `test_doctests.py` to ignore certain docstring examples based on the build architecture (such as ktruss in CUDA 11.4)
4. Passing MG `katz_centrality` testing

This PR also closes #2025.

Authors:
  - https://github.com/betochimas

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Joseph Nke (https://github.com/jnke2016)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@betochimas betochimas

Labels
bug Something isn't working
Projects
None yet
Milestone
22.06
Development

Successfully merging a pull request may close this issue.

Refactored SG hits and MG katz_centrality betochimas/cugraph
4 participants
@rlratzel @BradReesWork @betochimas @acostadon