Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Update CmakeLists.txt to update gcc & nvcc versions #1677

Closed
seunghwak opened this issue Jun 18, 2021 · 0 comments · Fixed by #1836
Closed

[ENH] Update CmakeLists.txt to update gcc & nvcc versions #1677

seunghwak opened this issue Jun 18, 2021 · 0 comments · Fixed by #1836
Labels
improvement Improvement / enhancement to an existing function
Milestone
21.10

Comments

@seunghwak
Copy link
Contributor

Describe the solution you'd like
cuGraph currently requires gcc 9.3+ and nvcc 11.0+.
https://github.com/rapidsai/cugraph/blob/branch-21.08/SOURCEBUILD.md

We'd better check this in CMake to save users from puzzling compile errors
@seunghwak seunghwak added the ? - Needs Triage Need team to review and classify label Jun 18, 2021
@seunghwak seunghwak changed the title [ENH] Update CmakeFiles to update gcc & nvcc versions [ENH] Update CmakeLists.txt to update gcc & nvcc versions Jun 18, 2021
@ChuckHastings ChuckHastings added this to the 21.10 milestone Jul 30, 2021
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function and removed ? - Needs Triage Need team to review and classify labels Aug 5, 2021
@ChuckHastings ChuckHastings mentioned this issue Sep 22, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Sep 22, 2021
@ChuckHastings
add compiler version checks to cmake to fail early (#1836)
677b9f3 
Closes #1677 

We require gcc 9.3 and nvcc 11.0 from a feature perspective.  This change forces make to validate that someone building cugraph has these versions.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: #1836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
21.10
Development

Successfully merging a pull request may close this issue.

add compiler version checks to cmake to fail early ChuckHastings/cugraph
3 participants
@BradReesWork @ChuckHastings @seunghwak