Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Reduce the testing done by CI #1555

Closed
ChuckHastings opened this issue Apr 22, 2021 · 2 comments · Fixed by #1989
Closed

[FEA] Reduce the testing done by CI #1555

ChuckHastings opened this issue Apr 22, 2021 · 2 comments · Fixed by #1989
Assignees
@ChuckHastings
Labels
improvement Improvement / enhancement to an existing function
Milestone
22.02

Comments

@ChuckHastings
Copy link
Collaborator

The amount of testing we currently do in CI is causing timeout issues. We need to reevaluate what we are testing as part of CI to reduce the total time.

As an example, I ran make test on my linux box and saw the following two results appear:

      Start  2: BETWEENNESS_TEST
 2/38 Test  #2: BETWEENNESS_TEST ...........................   Passed  843.43 sec
      Start  3: EDGE_BETWEENNESS_TEST
 3/38 Test  #3: EDGE_BETWEENNESS_TEST ......................   Passed  409.24 sec

It seems like 20 minutes spent running these two C++ unit tests is really too high. The point of the unit tests is to verify the functionality of the code, not to measure performance (that should be a different suite of tests).
@ChuckHastings ChuckHastings added the ? - Needs Triage Need team to review and classify label Apr 22, 2021
@ChuckHastings ChuckHastings mentioned this issue Apr 23, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Apr 23, 2021
@ChuckHastings
Update our thrust version to 1.12 (#1553)
53be1f9 
cuDF and RMM have updated to version 1.12, we have been requested to update as well.

This PR is dependent on:
* rapidsai/raft#211
* rapidsai/cuhornet#49

Also disabled some unit tests to reduce our CI time, since we've started seeing timeouts.  Issue #1555 will fully address this issue.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: #1553
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function and removed ? - Needs Triage Need team to review and classify inactive-30d labels Aug 5, 2021
@BradReesWork BradReesWork added this to the 21.10 milestone Aug 5, 2021
@BradReesWork BradReesWork modified the milestones: 21.10, 21.12 Oct 6, 2021
@ChuckHastings ChuckHastings modified the milestones: 21.12, 22.02 Nov 15, 2021
@ChuckHastings ChuckHastings mentioned this issue Dec 10, 2021
Merged
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@rapids-bot rapids-bot bot closed this as completed in #1989 Jan 5, 2022
rapids-bot bot pushed a commit that referenced this issue Jan 5, 2022
@ChuckHastings
make C++ tests run faster (fewer tests) (#1989)
c49f049 
Modified the most expensive C++ tests to run fewer tests.  Closes #1555 

Added an option (like in the rmat tests) to run a specific test file if the developer wants to manually run larger tests.  For example:

```tests/COARSEN_GRAPH_TEST --gtest_filter=file_ben* --test_file_name=test/datasets/ljournal-2008.mtx```

The smaller graphs *should* be small enough to test things.  Once we add C++ code coverage we should be able to verify this.

On my local workstation this reduced the time spent executing the C++ tests by about 25 minutes.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Kumar Aatish (https://github.com/kaatish)
  - Seunghwa Kang (https://github.com/seunghwak)

URL: #1989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChuckHastings ChuckHastings

Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
22.02
Development

Successfully merging a pull request may close this issue.

make C++ tests run faster (fewer tests) ChuckHastings/cugraph
2 participants
@BradReesWork @ChuckHastings