merge branch-24.12 into branch-25.02 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CUDA 11.4 is only tested in nightly CI (not on PRs) for this project. This project doesn't support CUDA 11.4 (because the versions of PyTorch it is compatible with don't), so rapidsai#89 turned off most of those CUDA 11.4 test jobs. That worked for wheels, but conda tests need to be turned off as well. ```text tests/data/test_dask_graph_store.py::test_get_edge_index[multi_edge_multi_vertex_graph_1-cudf] - AssertionError: Torch not compiled with CUDA enabled ``` ([build link](https://github.com/rapidsai/cugraph-gnn/actions/runs/12198233986/job/34029537082#step:8:141493)) This skips nightly tests against CUDA 11.4. ## Notes for Reviewers ### How I tested this Triggered a run of the nightly test job from this branch ([by clicking "Run workflow" here](https://github.com/rapidsai/cugraph-gnn/actions/workflows/test.yaml)), using the latest nightly packages: * **use workflow from:** `pull-request/91` * **branch:** `branch-24.12` * **date:** `2024-12-06` * **sha:** `7ec8ace3cf7007dcca796e484f587af77d328e8f` (from https://github.com/rapidsai/cugraph-gnn/commits/branch-24.12/) Build link: https://github.com/rapidsai/cugraph-gnn/actions/runs/12203424243/job/34046336319
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
jameslamb
added
improvement
jameslamb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92
Fixes forward-merge conflicts, per https://docs.rapids.ai/maintainers/forward-merger