-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gpuci_mamba_retry on Java CI. #9983
Conversation
9b9d285
to
fae66fe
Compare
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9983 +/- ##
================================================
- Coverage 10.49% 10.45% -0.04%
================================================
Files 119 119
Lines 20305 20417 +112
================================================
+ Hits 2130 2134 +4
- Misses 18175 18283 +108
Continue to review full report at Codecov.
|
Hmmm. The good news is that |
Co-authored-by: AJ Schmidt <[email protected]>
CI is failing because CMake cannot find the JNI despite The issue is arising because Bash script to reproduce the issue: #!/bin/bash
# Enable activating conda environments
. $CONDA_PREFIX/etc/profile.d/conda.sh
export MAMBA_NO_BANNER=1
echo "---------conda---------"
conda --version
conda create -y -q -n conda_jdk_test
conda activate conda_jdk_test
conda install -y -q "openjdk=8.*"
echo "'which java' returns $(which java)"
echo "JAVA_HOME=${JAVA_HOME}"
conda deactivate
conda env remove --name conda_jdk_test
echo "-------end conda-------"
echo
echo "---------mamba---------"
mamba --version
mamba create -y -q -n mamba_jdk_test mamba
conda activate mamba_jdk_test
mamba install -y -q "openjdk=8.*"
echo "'which java' returns $(which java)"
echo "JAVA_HOME=${JAVA_HOME}" # This is the bug -- JAVA_HOME is not set.
conda deactivate
echo "Retry mamba after re-activating:"
conda activate mamba_jdk_test
mamba install -y -q "openjdk=8.*"
echo "'which java' returns $(which java)"
echo "JAVA_HOME=${JAVA_HOME}" # This is the bug -- JAVA_HOME is not set.
conda deactivate
conda env remove --name mamba_jdk_test
echo "-------end mamba-------" Simplified output:
It appears that this PR is related: conda/conda#10783 and particularly this comment: conda/conda#10783 (comment)
|
Thanks @jlowe @ajschmidt8 @raydouglass for the pointers -- Java CI is now passing, this is ready for review and merge. ☕ 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bdice for driving this!
Thank you @bdice ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find! I wonder if there's an upstream mamba
bug about this that we can track so that we can eventually remove this workaround.
@ajschmidt8 There’s a conda issue that I Iinked above: conda/conda#10783 The issue is that mamba cannot currently hook into conda to trigger the post-install activation. |
@gpucibot merge |
For the sake of completeness, here's an analysis of the CI runtime before/after this PR. Comparing the CI build logs, I see a significant improvement in run time by switching to mamba.
|
Resolves #9976.