Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support
args=
inSeries.apply
#9982Support
args=
inSeries.apply
#9982Changes from 33 commits
cff4d1f
4b7181d
be9deb4
c3ed817
76fe430
9131e23
4e9c876
af56462
21c4b95
1feed89
c77333d
3543e15
caff641
8338061
ebdd9d4
ac442b2
d87fcbe
460a45d
e1635f8
34f5c57
841cad8
c784b12
809b4c1
1f320e6
b099ddc
ac0bb27
f9b6bbd
18c256d
25ffcdb
1844344
c84ac0a
8d41c89
2415a98
643d55e
0af638f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we always generate a kernel with
len(self)
tasks, do we really need to passlen(self)
as one of thelaunch_args
? AFAICT that's just used to avoid out of bounds accesses, but it looks like we always launch a grid with one thread per row right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had taken the numba docs for
forall
to mean that inserting this check was a requirement for kernels that expect to be configured this way. Indeed, taking it out leads to numerous tests failing due to nulls being in the wrong places everywhere. My assumption was that something was happening insideforall
that caused unpredictable behavior if this guard was not included. cc @gmarkall for more insight.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess maybe numba must be doing something where it generates only a limited set of kernels (maybe templates?) based on the block size and then dispatches to the closest size possible based on the argument to
forall
? I would be curious to learn more about how this works from @gmarkall. It sounds like you should ignore my suggestion to change anything here though.