Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW]Remove str.subword_tokenize #9968

Merged
merged 5 commits into from
Jan 5, 2022
Merged

[REVIEW]Remove str.subword_tokenize #9968

merged 5 commits into from
Jan 5, 2022

Conversation

VibhuJawa
Copy link
Member

This PR resolves #8604 and #9447

@VibhuJawa VibhuJawa requested review from a team as code owners January 4, 2022 16:54
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jan 4, 2022
@VibhuJawa VibhuJawa added breaking Breaking change and removed libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. labels Jan 4, 2022
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jan 4, 2022
@VibhuJawa VibhuJawa added improvement Improvement / enhancement to an existing function tech debt labels Jan 4, 2022
@VibhuJawa VibhuJawa changed the title [WIP]Removed str.subword_tokenize [REVIEW]Removed str.subword_tokenize Jan 4, 2022
@VibhuJawa VibhuJawa changed the title [REVIEW]Removed str.subword_tokenize [REVIEW]Remove str.subword_tokenize Jan 4, 2022
@VibhuJawa VibhuJawa added 4 - Needs cuDF (Python) Reviewer 4 - Needs Review Waiting for reviewer to review or respond labels Jan 4, 2022
@codecov
Copy link

codecov bot commented Jan 5, 2022 •
edited
Loading

Codecov Report

Merging #9968 (62606d3) into branch-22.02 (967a333) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9968      +/-   ##
================================================
- Coverage         10.49%   10.42%   -0.07%     
================================================
  Files               119      119              
  Lines             20305    20475     +170     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18341     +166
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7233765...62606d3. Read the comment docs.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs Review Waiting for reviewer to review or respond labels Jan 5, 2022
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3e893a6 into rapidsai:branch-22.02 Jan 5, 2022
@davidwendt davidwendt mentioned this pull request Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@cwharris cwharris cwharris approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Deprecate ser.str.subword_tokenize API in favor of cudf.core.subword_tokenizer.SubwordTokenizer
4 participants
@VibhuJawa @galipremsagar @cwharris @davidwendt