Fix regression HostColumnVectorCore requiring native libs #9948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
added
bug
|
build |
|
rerun tests |
revans2
approved these changes
Jan 5, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9948 +/- ##
================================================
- Coverage 10.49% 10.42% -0.07%
================================================
Files 119 119
Lines 20305 20475 +170
================================================
+ Hits 2130 2134 +4
- Misses 18175 18341 +166
Continue to review full report at Codecov.
|
gerashegalov
reviewed
Jan 5, 2022
Comment on lines
+597
to
+605
| if (data != null) { | ||
| data.close(); | ||
| } | ||
| if (offsets != null) { | ||
| offsets.close(); | ||
| } | ||
| if (valid != null) { | ||
| valid.close(); | ||
| } |
There was a problem hiding this comment.
We could benefit from some 3rd-party or our own flavor of API callable like this: IOUtils.close(data, offsets, valid);
gerashegalov
approved these changes
Jan 5, 2022
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9485 regressed the fix in #9332. This restores the fix. It also eliminates the problematic
ColumnVector.closeBufferswhich, despite the plurality in the name, only closed one buffer and had dubious utility in converting throwables into runtime exceptions.