Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated method parameter from merge and join. #9944

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 21, 2021

This PR removes the deprecated method parameter from DataFrame.merge and DataFrame.join. This resolves #9353 and follows up on #9291.

@bdice bdice requested a review from a team as a code owner December 21, 2021 19:59
@bdice bdice self-assigned this Dec 21, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 21, 2021
@bdice bdice added breaking Breaking change deprecation improvement Improvement / enhancement to an existing function Python Affects Python cuDF API. and removed Python Affects Python cuDF API. labels Dec 21, 2021
@bdice bdice removed the tech debt label Dec 21, 2021
@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Dec 23, 2021
@galipremsagar
Copy link
Contributor

rerun tests

@vyasr
Copy link
Contributor

vyasr commented Jan 4, 2022

@bdice looks like there are a couple more tests that need fixing here.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #9944 (b61ad03) into branch-22.02 (967a333) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9944      +/-   ##
================================================
- Coverage         10.49%   10.41%   -0.08%     
================================================
  Files               119      119              
  Lines             20305    20494     +189     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18360     +185     
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c4816...b61ad03. Read the comment docs.

@bdice
Copy link
Contributor Author

bdice commented Jan 13, 2022

@gpucibot merge

1 similar comment
@bdice
Copy link
Contributor Author

bdice commented Jan 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4950a7a into rapidsai:branch-22.02 Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEPRECATION] Remove method parameters to merge and join in v22.02
3 participants