Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename aggregate_metadata in writer to fix name collision #9938

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Rename aggregate_metadata in writer to fix name collision #9938

merged 2 commits into from
Jan 5, 2022

Conversation

devavret
Copy link
Contributor

Fixes #9935

@devavret devavret requested a review from a team as a code owner December 20, 2021 22:23
@devavret devavret requested review from vuule and nvdbaranec December 20, 2021 22:23
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 20, 2021
@devavret devavret added bug Something isn't working non-breaking Non-breaking change labels Dec 20, 2021
@devavret
Copy link
Contributor Author

rerun tests

2 similar comments
@devavret
Copy link
Contributor Author

rerun tests

@devavret
Copy link
Contributor Author

devavret commented Jan 4, 2022

rerun tests

@vuule
Copy link
Contributor

vuule commented Jan 4, 2022

@devavret Any idea why the error happens only in debug build?

vuule
vuule approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also rename the reader counterpart to aggregate_reader_metadata?

@codecov

This comment has been minimized.

Sign in to view
@devavret
Copy link
Contributor Author

devavret commented Jan 4, 2022 •
edited
Loading

@devavret Any idea why the error happens only in debug build?

Nope. It should've broken in release. Neither is in an anonymous namespace.

@devavret
Copy link
Contributor Author

devavret commented Jan 5, 2022

Java failure seems unrelated because I'm seeing this on other PRs as well.

@devavret
Copy link
Contributor Author

devavret commented Jan 5, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f7cc6a0 into rapidsai:branch-22.02 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdbaranec nvdbaranec nvdbaranec approved these changes

@vuule vuule vuule approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

Assignees
No one assigned
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Segfault in libcudf debug build running PARQUET_TEST
4 participants
@devavret @vuule @karthikeyann @nvdbaranec