Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Enable transpose for string columns in cudf python #9937

Merged
merged 2 commits into from
Jan 4, 2022
Merged

[REVIEW] Enable transpose for string columns in cudf python #9937

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fec9420
enable transpose for string columns
galipremsagar Dec 20, 2021
b91b37f
Merge branch 'rapidsai:branch-22.02' into 9930
galipremsagar Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions python/cudf/cudf/_lib/transpose.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,19 @@ def transpose(source):
return source

cats = None
dtype = source._columns[0].dtype
columns = source._columns
dtype = columns[0].dtype

if is_categorical_dtype(dtype):
if any(not is_categorical_dtype(c.dtype) for c in source._columns):
if any(not is_categorical_dtype(c.dtype) for c in columns):
raise ValueError('Columns must all have the same dtype')
cats = list(c.categories for c in source._columns)
cats = list(c.categories for c in columns)
cats = cudf.core.column.concat_columns(cats).unique()
source = cudf.core.frame.Frame(index=source._index, data=[
(name, col._set_categories(cats, is_unique=True).codes)
for name, col in source._data.items()
])
elif dtype.kind in 'OU':
raise NotImplementedError('Cannot transpose string columns')
elif any(c.dtype != dtype for c in source._columns):
elif any(c.dtype != dtype for c in columns):
raise ValueError('Columns must all have the same dtype')

cdef pair[unique_ptr[column], table_view] c_result
Expand Down
2 changes: 1 addition & 1 deletion python/cudf/cudf/tests/test_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1797,7 +1797,7 @@ def test_dataframe_shape_empty():

@pytest.mark.parametrize("num_cols", [1, 2, 10])
@pytest.mark.parametrize("num_rows", [1, 2, 20])
@pytest.mark.parametrize("dtype", dtypes)
@pytest.mark.parametrize("dtype", dtypes + ["object"])
@pytest.mark.parametrize("nulls", ["none", "some", "all"])
def test_dataframe_transpose(nulls, num_cols, num_rows, dtype):
# In case of `bool` dtype: pandas <= 1.2.5 type-casts
Expand Down