Refactoring ceil/round/floor code for datetime64[ns] types #9926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankanand007
added
2 - In Progress
mayankanand007
requested review from
robertmaynard,
rgsl888prabhu and
marlenezw
mayankanand007
removed request for
robertmaynard,
rgsl888prabhu and
marlenezw
mayankanand007
changed the title
bdice
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9926 +/- ##
================================================
- Coverage 10.49% 10.40% -0.09%
================================================
Files 119 119
Lines 20305 20507 +202
================================================
+ Hits 2130 2134 +4
- Misses 18175 18373 +198
Continue to review full report at Codecov.
|
shwina
reviewed
Dec 17, 2021
shwina
approved these changes
Dec 17, 2021
bdice
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Thanks @mayankanand007! This currently has 2 approvals. I did a final pass and I think it's ready to merge. I appreciate your hard work!
|
@gpucibot merge |
1 similar comment
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #9820 where @bdice and @vyasr raised the point of having a design such that we avoid writing bunch of boilerplate code, which is common in the implementations of ceil/round/floor. The aim is to reduce the total number of functions, as well as have a cleaner design.