Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise in query if dtype is not supported #9921

Merged
merged 7 commits into from
Jan 11, 2022
Merged

Raise in query if dtype is not supported #9921

merged 7 commits into from
Jan 11, 2022

Conversation

brandon-b-miller
Copy link
Contributor

Closes #9894

@brandon-b-miller brandon-b-miller requested a review from a team as a code owner December 16, 2021 15:13
@brandon-b-miller brandon-b-miller self-assigned this Dec 16, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 16, 2021
@brandon-b-miller brandon-b-miller added 2 - In Progress Currently a work in progress numba Numba issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 16, 2021
vyasr
vyasr reviewed Dec 16, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a test for this error?

python/cudf/cudf/utils/queryutils.py Outdated Show resolved Hide resolved
@brandon-b-miller brandon-b-miller added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021 •
edited
Loading

Codecov Report

Merging #9921 (76bf19f) into branch-22.02 (967a333) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9921      +/-   ##
================================================
- Coverage         10.49%   10.41%   -0.08%     
================================================
  Files               119      119              
  Lines             20305    20485     +180     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18351     +176
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc25f3d...76bf19f. Read the comment docs.

vyasr
vyasr approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor questions on the test, but generally ready to go.

python/cudf/cudf/tests/test_query.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_query.py Show resolved Hide resolved
@brandon-b-miller
Copy link
Contributor Author

rerun tests

@brandon-b-miller
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3216342 into rapidsai:branch-22.02 Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@marlenezw marlenezw Awaiting requested review from marlenezw marlenezw is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@brandon-b-miller brandon-b-miller

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change numba Numba issue Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Improved error message when calling query() on expresions involving columns of string values
2 participants
@brandon-b-miller @vyasr