-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG FIX] In-place updates with loc or iloc don't work correctly when the LHS has more than one column #9918
Conversation
This PR has been labeled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! There's a lot that can generally be improved in the indexing code but very much out of scope for this PR.
Appreciate the attention to testing here 👍 Nice work @skirui-source and @isVoid!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and pushed a commit to internalize the shape_mismatch_error
to _shape_mismatch_error
. Other than that this PR looks good to go. 🎉
Dismissing since the review has been addressed.
@gpucibot merge |
Fixes: #7377
This PR enables to
setitem
using a scalar value, dataframe or array/list iterable in bothDataframeLocIndexer
andDataFrameIlocIndexer
. Only the following cases are currently supported in cudf: