Replace thrust/std::get with structured bindings
#9915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codereport
added
3 - Ready for Review
ttnghia
approved these changes
Dec 15, 2021
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9915 +/- ##
================================================
- Coverage 10.49% 10.40% -0.09%
================================================
Files 119 119
Lines 20305 20503 +198
================================================
+ Hits 2130 2134 +4
- Misses 18175 18369 +194
Continue to review full report at Codecov.
|
hyperbolic2346
approved these changes
Dec 16, 2021
codereport
added
5 - Ready to Merge
|
@gpucibot merge |
codereport
changed the title
thrust/std::get with structure bindingsthrust/std::get with structured bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While watching @bdice and @isVoid's Better Code talk, I noticed a pair of
thrust::gets that could be replaced by structured bindings. I did a quick search and found all the places the clean up could be done. That is what this PR does.