Add cudf::strings::extract_all API #9909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9909 +/- ##
================================================
- Coverage 10.49% 10.41% -0.08%
================================================
Files 119 119
Lines 20305 20480 +175
================================================
+ Hits 2130 2134 +4
- Misses 18175 18346 +171
Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
bdice
requested changes
Dec 17, 2021
robertmaynard
approved these changes
Dec 17, 2021
bdice
approved these changes
Dec 20, 2021
hyperbolic2346
approved these changes
Dec 21, 2021
hyperbolic2346
approved these changes
Jan 4, 2022
|
rerun tests |
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 27, 2022
Reference #9856 specifically #9856 (comment) Adds `cudf::strings::findall_record` which was initially implemented in nvstrings but not ported over since LIST column types did not exist at the time and returning a vector of small columns was very inefficient. This API should also allow using the current python function `cudf.str.findall()` with the `expand=False` parameter more effectively. A follow-on PR will address these python changes. This PR reorganizes the libcudf strings _find_ source files into the `cpp/src/strings/search` subdirectory as well. Also, `findall()` has only a regex version so the `_re` suffix is dropped from the name in the libcudf implementation. The python changes in this PR address only the name change and the addition of the new API in the cython interface. Depends on #9909 -- shares the `cudf::strings::detail::count_matches()` utility function. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Vyas Ramasubramani (https://github.com/vyasr) URL: #9911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9856
Adds a new
cudf::strings::extract_allAPI that returns a LIST column of extracted strings given a regex pattern.This is similar to nvstrings version of
extractcalledextract_recordbut returns groups from all matches in each string instead of just the first match. Here is pseudo code of it's behavior on various strings input:Each match results in two groups as specified in the regex pattern.
Also reorganized the extract source code into
src/strings/extractdirectory.The match-counting has been factored out into new
count_matches.cuhsince it will become common code used withfindall_recordin a follow on PR.