Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the java build after parquet partitioning support #9908

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Dec 15, 2021

This fixes the java build after #9810 went in.

There is a lot of copy/paste in this first draft, because I just wanted to get something to work. Not sure if it is worth going back to make it common everywhere.

@revans2 revans2 added bug Something isn't working 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. non-breaking Non-breaking change labels Dec 15, 2021
@revans2 revans2 self-assigned this Dec 15, 2021
@revans2 revans2 requested a review from a team as a code owner December 15, 2021 12:08
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #9908 (bbff81b) into branch-22.02 (967a333) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head bbff81b differs from pull request most recent head 8aa944b. Consider uploading reports for the commit 8aa944b to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9908      +/-   ##
================================================
- Coverage         10.49%   10.40%   -0.09%     
================================================
  Files               119      119              
  Lines             20305    20503     +198     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18369     +194     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78d12bb...8aa944b. Read the comment docs.

Copy link
Contributor

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not thrilled with the amount of copy and paste, but prefer to get the Java build working ASAP. I assume the ORC writer will get the same sort of change eventually, and at that point it would make sense to use a common function again.

@revans2
Copy link
Contributor Author

revans2 commented Dec 15, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 38631a6 into rapidsai:branch-22.02 Dec 15, 2021
@revans2 revans2 deleted the fix_jni_build branch December 15, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants