Add zlib to cudfjni link when using static libcudf library dependency #9890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
added
bug
abellina
approved these changes
Dec 11, 2021
|
@gpucibot merge |
ttnghia
approved these changes
Dec 11, 2021
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9890 +/- ##
================================================
- Coverage 10.49% 10.42% -0.07%
================================================
Files 119 119
Lines 20305 20479 +174
================================================
+ Hits 2130 2134 +4
- Misses 18175 18345 +170
Continue to review full report at Codecov.
|
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Java bindings use libcudf as a static library dependency, the resulting link is missing zlib as a dynamic link dependency. This can result in runtime errors such as
undefined symbol: inflateInit2_when trying to load a file using gzip compression. This adds zlib to the cudfjni link when using libcudf.a as the cudf dependency.