Add dictionary support to cudf::copy_if_else #9887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9887 +/- ##
================================================
- Coverage 10.49% 10.42% -0.07%
================================================
Files 119 119
Lines 20305 20473 +168
================================================
+ Hits 2130 2134 +4
- Misses 18175 18339 +164
Continue to review full report at Codecov.
|
davidwendt
added
3 - Ready for Review
ttnghia
reviewed
Dec 14, 2021
ttnghia
reviewed
Dec 14, 2021
ttnghia
approved these changes
Dec 14, 2021
harrism
approved these changes
Dec 14, 2021
I think the current documentation is sufficiently vague enough. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9885
Adds support for dictionary column types to
cudf::copy_if_else. The column/scalar versions of this API will accept a scalar type that matches the dictionary's key type. The column/column version will accept 2 dictionary columns with matching key types. The result of the function will be a dictionary that incorporates both sets of keys or the scalar value as appropriate.