Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG FIX] TimedeltaIndex constructor raises an AttributeError. #9884

Merged
merged 14 commits into from
Dec 17, 2021
Merged

[BUG FIX] TimedeltaIndex constructor raises an AttributeError. #9884

merged 14 commits into from
Dec 17, 2021

Conversation

skirui-source
Copy link
Contributor

@skirui-source skirui-source commented Dec 9, 2021 •
edited by galipremsagar
Loading

Fixes: #9829

This PR fixes TimedeltaIndex constructor invocation by handling NaT values replacement with nulls.

@skirui-source skirui-source added bug Something isn't working Python Affects Python cuDF API. labels Dec 9, 2021
@skirui-source skirui-source self-assigned this Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021 •
edited
Loading

Codecov Report

Merging #9884 (8d2dcf4) into branch-22.02 (967a333) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9884      +/-   ##
================================================
- Coverage         10.49%   10.40%   -0.09%     
================================================
  Files               119      119              
  Lines             20305    20507     +202     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18373     +198
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d7acc...8d2dcf4. Read the comment docs.

@skirui-source skirui-source added the non-breaking Non-breaking change label Dec 11, 2021
@skirui-source skirui-source marked this pull request as ready for review December 11, 2021 01:03
@skirui-source skirui-source requested a review from a team as a code owner December 11, 2021 01:03
bdice
bdice requested changes Dec 13, 2021
View reviewed changes
python/cudf/cudf/core/column/timedelta.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/timedelta.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/timedelta.py Outdated Show resolved Hide resolved
bdice
bdice requested changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments attached.

python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
@skirui-source skirui-source requested a review from bdice December 16, 2021 03:13
@bdice
Copy link
Contributor

bdice commented Dec 17, 2021

@galipremsagar This can be merged once you approve. Thanks!

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 17, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 23cafcf into rapidsai:branch-22.02 Dec 17, 2021
@skirui-source skirui-source deleted the TimedeltaIndex branch December 20, 2021 03:04
@skirui-source skirui-source restored the TimedeltaIndex branch January 6, 2022 04:01
@skirui-source skirui-source deleted the TimedeltaIndex branch January 6, 2022 04:01
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@marlenezw marlenezw Awaiting requested review from marlenezw marlenezw is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid

Assignees

@skirui-source skirui-source

Labels
4 - Needs Review Waiting for reviewer to review or respond 5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] TimedeltaIndex constructor raises an AttributeError.
4 participants
@skirui-source @bdice @galipremsagar @vyasr