-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regex_flags parameter to strings replace_re functions #9878
Add regex_flags parameter to strings replace_re functions #9878
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9878 +/- ##
================================================
- Coverage 10.49% 10.42% -0.07%
================================================
Files 119 119
Lines 20305 20473 +168
================================================
+ Hits 2130 2134 +4
- Misses 18175 18339 +164
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks!
@gpucibot merge |
Closes #9845
Adds a
cudf::strings::regex_flags
parameter to thecudf::strings::replace_re
functions so the matching logic will be the same as forcudf::strings::contains_re
which already has this parameter.This is a breaking change since it adds this new parameter and changes the default behavior. The previous default behavior is equivalent to specifying the
regex_flags::MULTILINE
flag now to be consistent with the default behavior ofcontains_re
.