Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null handling for structs min and arg_min in groupby, groupby scan, reduction, and inclusive_scan #9864

Merged
Merged
Prev Previous commit
Next Next commit
Fix typo
ttnghia committed Dec 15, 2021
commit b1b3000a0e1487f2e249621c3073df8ed6cddc16
2 changes: 1 addition & 1 deletion cpp/src/groupby/sort/group_scan_util.cuh
Original file line number Diff line number Diff line change
@@ -194,7 +194,7 @@ struct group_scan_functor<K,
auto const binop_generator =
cudf::reduction::detail::comparison_binop_generator(values, is_min_op, stream);

// Create a gather map contaning indices of the prefix min/max elements within each group.
// Create a gather map containing indices of the prefix min/max elements within each group.
auto gather_map = rmm::device_uvector<size_type>(values.size(), stream);
thrust::inclusive_scan_by_key(rmm::exec_policy(stream),
group_labels.begin(),