Add clang-tidy to libcudf

cpp/benchmarks/io/orc/orc_reader_benchmark.cpp

@@ -40,7 +40,7 @@ void BM_orc_read_varying_input(benchmark::State& state)
   cudf::size_type const run_length  = state.range(2);
   cudf_io::compression_type const compression =
     state.range(3) ? cudf_io::compression_type::SNAPPY : cudf_io::compression_type::NONE;
-  auto const source_type = static_cast<io_type>(state.range(4));
+  io_type const source_type = static_cast<io_type>(state.range(4));
 
   data_profile table_data_profile;
   table_data_profile.set_cardinality(cardinality);

cpp/benchmarks/io/orc/orc_writer_benchmark.cpp

@@ -40,7 +40,7 @@ void BM_orc_write_varying_inout(benchmark::State& state)
   cudf::size_type const run_length  = state.range(2);
   cudf_io::compression_type const compression =
     state.range(3) ? cudf_io::compression_type::SNAPPY : cudf_io::compression_type::NONE;
-  auto const sink_type = static_cast<io_type>(state.range(4));
+  io_type const sink_type = static_cast<io_type>(state.range(4));
 
   data_profile table_data_profile;
   table_data_profile.set_cardinality(cardinality);

cpp/benchmarks/io/parquet/parquet_reader_benchmark.cpp

@@ -40,7 +40,7 @@ void BM_parq_read_varying_input(benchmark::State& state)
   cudf::size_type const run_length  = state.range(2);
   cudf_io::compression_type const compression =
     state.range(3) ? cudf_io::compression_type::SNAPPY : cudf_io::compression_type::NONE;
-  auto const source_type = static_cast<io_type>(state.range(4));
+  io_type const source_type = static_cast<io_type>(state.range(4));
 
   data_profile table_data_profile;
   table_data_profile.set_cardinality(cardinality);

cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp

@@ -40,7 +40,7 @@ void BM_parq_write_varying_inout(benchmark::State& state)
   cudf::size_type const run_length  = state.range(2);
   cudf_io::compression_type const compression =
     state.range(3) ? cudf_io::compression_type::SNAPPY : cudf_io::compression_type::NONE;
-  auto const sink_type = static_cast<io_type>(state.range(4));
+  io_type const sink_type = static_cast<io_type>(state.range(4));
 
   data_profile table_data_profile;
   table_data_profile.set_cardinality(cardinality);

cpp/include/cudf/io/text/data_chunk_source_factories.hpp

@@ -41,8 +41,8 @@ class device_span_data_chunk : public device_data_chunk {
  public:
   device_span_data_chunk(device_span<char const> data) : _data(data) {}
 
-  [[nodiscard]] char const* data() const override { return _data.data(); }
-  [[nodiscard]] std::size_t size() const override { return _data.size(); }
+  char const* data() const override { return _data.data(); }
+  std::size_t size() const override { return _data.size(); }
   operator device_span<char const>() const override { return _data; }
 
  private:
@@ -53,8 +53,8 @@ class device_uvector_data_chunk : public device_data_chunk {
  public:
   device_uvector_data_chunk(rmm::device_uvector<char>&& data) : _data(std::move(data)) {}
 
-  [[nodiscard]] char const* data() const override { return _data.data(); }
-  [[nodiscard]] std::size_t size() const override { return _data.size(); }
+  char const* data() const override { return _data.data(); }
+  std::size_t size() const override { return _data.size(); }
   operator device_span<char const>() const override { return _data; }
 
  private:
@@ -171,7 +171,7 @@ class device_span_data_chunk_reader : public data_chunk_reader {
 class file_data_chunk_source : public data_chunk_source {
  public:
   file_data_chunk_source(std::string filename) : _filename(filename) {}
-  [[nodiscard]] std::unique_ptr<data_chunk_reader> create_reader() const override
+  std::unique_ptr<data_chunk_reader> create_reader() const override
   {
     return std::make_unique<istream_data_chunk_reader>(
       std::make_unique<std::ifstream>(_filename, std::ifstream::in));
@@ -187,7 +187,7 @@ class file_data_chunk_source : public data_chunk_source {
 class string_data_chunk_source : public data_chunk_source {
  public:
   string_data_chunk_source(std::string const& data) : _data(data) {}
-  [[nodiscard]] std::unique_ptr<data_chunk_reader> create_reader() const override
+  std::unique_ptr<data_chunk_reader> create_reader() const override
   {
     return std::make_unique<istream_data_chunk_reader>(std::make_unique<std::istringstream>(_data));
   }
@@ -202,7 +202,7 @@ class string_data_chunk_source : public data_chunk_source {
 class device_span_data_chunk_source : public data_chunk_source {
  public:
   device_span_data_chunk_source(device_span<char const> data) : _data(data) {}
-  [[nodiscard]] std::unique_ptr<data_chunk_reader> create_reader() const override
+  std::unique_ptr<data_chunk_reader> create_reader() const override
   {
     return std::make_unique<device_span_data_chunk_reader>(_data);
   }

cpp/include/cudf/strings/string_view.hpp

@@ -51,20 +51,20 @@ class string_view {
   /**
    * @brief Return the number of bytes in this string
    */
-  CUDF_HOST_DEVICE [[nodiscard]] inline size_type size_bytes() const { return _bytes; }
+  CUDF_HOST_DEVICE inline size_type size_bytes() const { return _bytes; }
   /**
    * @brief Return the number of characters in this string
    */
-  __device__ [[nodiscard]] inline size_type length() const;
+  __device__ inline size_type length() const;
   /**
    * @brief Return a pointer to the internal device array
    */
-  CUDF_HOST_DEVICE [[nodiscard]] inline const char* data() const { return _data; }
+  CUDF_HOST_DEVICE inline const char* data() const { return _data; }
 
   /**
    * @brief Return true if string has no characters
    */
-  CUDF_HOST_DEVICE [[nodiscard]] inline bool empty() const { return size_bytes() == 0; }
+  CUDF_HOST_DEVICE inline bool empty() const { return size_bytes() == 0; }
 
   /**
    * @brief Handy iterator for navigating through encoded characters.
@@ -109,11 +109,11 @@ class string_view {
   /**
    * @brief Return new iterator pointing to the beginning of this string
    */
-  __device__ [[nodiscard]] inline const_iterator begin() const;
+  __device__ inline const_iterator begin() const;
   /**
    * @brief Return new iterator pointing past the end of this string
    */
-  __device__ [[nodiscard]] inline const_iterator end() const;
+  __device__ inline const_iterator end() const;
 
   /**
    * @brief Return single UTF-8 character at the given character position
@@ -126,7 +126,7 @@ class string_view {
    *
    * @param pos Character position
    */
-  __device__ [[nodiscard]] inline size_type byte_offset(size_type pos) const;
+  __device__ inline size_type byte_offset(size_type pos) const;
 
   /**
    * @brief Comparing target string with this string. Each character is compared
@@ -141,7 +141,7 @@ class string_view {
    *            not match is greater in the arg string, or all compared characters
    *            match but the arg string is longer.
    */
-  __device__ [[nodiscard]] inline int compare(const string_view& str) const;
+  __device__ inline int compare(const string_view& str) const;
   /**
    * @brief Comparing target string with this string. Each character is compared
    * as a UTF-8 code-point value.
@@ -274,7 +274,7 @@ class string_view {
    * @param length Number of characters from start to include in the sub-string.
    * @return New instance pointing to a subset of the characters within this instance.
    */
-  __device__ [[nodiscard]] inline string_view substr(size_type start, size_type length) const;
+  __device__ inline string_view substr(size_type start, size_type length) const;
 
   /**
    * @brief Return minimum value associated with the string type
@@ -330,7 +330,7 @@ class string_view {
    * @param bytepos Byte position from start of _data.
    * @return The character position for the specified byte.
    */
-  __device__ [[nodiscard]] inline size_type character_offset(size_type bytepos) const;
+  __device__ inline size_type character_offset(size_type bytepos) const;
 };
 
 namespace strings {

cpp/include/cudf/structs/structs_column_view.hpp

@@ -60,7 +60,7 @@ class structs_column_view : public column_view {
    *
    * @throw cudf::logic error if this is an empty column
    */
-  [[nodiscard]] column_view get_sliced_child(int index) const;
+  column_view get_sliced_child(int index) const;
 };         // class structs_column_view;
 /** @} */  // end of group
 }  // namespace cudf

cpp/include/cudf/tdigest/tdigest_column_view.cuh

@@ -82,28 +82,28 @@ class tdigest_column_view : private column_view {
   /**
    * @brief Returns the parent column.
    */
-  [[nodiscard]] column_view parent() const;
+  column_view parent() const;
 
   /**
    * @brief Returns the column of centroids
    */
-  [[nodiscard]] lists_column_view centroids() const;
+  lists_column_view centroids() const;
 
   /**
    * @brief Returns the internal column of mean values
    */
-  [[nodiscard]] column_view means() const;
+  column_view means() const;
 
   /**
    * @brief Returns the internal column of weight values
    */
-  [[nodiscard]] column_view weights() const;
+  column_view weights() const;
 
   /**
    * @brief Returns an iterator that returns the size of each tdigest
    * in the column (each row is 1 digest)
    */
-  [[nodiscard]] auto size_begin() const
+  auto size_begin() const
   {
     return cudf::detail::make_counting_transform_iterator(
       0, tdigest_size{centroids().offsets_begin()});
@@ -113,13 +113,13 @@ class tdigest_column_view : private column_view {
    * @brief Returns the first min value for the column. Each row corresponds
    * to the minimum value for the accompanying digest.
    */
-  [[nodiscard]] double const* min_begin() const;
+  double const* min_begin() const;
 
   /**
    * @brief Returns the first max value for the column. Each row corresponds
    * to the maximum value for the accompanying digest.
    */
-  [[nodiscard]] double const* max_begin() const;
+  double const* max_begin() const;
 };
 
 }  // namespace tdigest

cpp/src/binaryop/compiled/util.cpp

@@ -64,7 +64,7 @@ template <typename BinaryOperator>
 struct is_binary_operation_supported {
   // For types where Out type is fixed. (eg. comparison types)
   template <typename TypeLhs, typename TypeRhs>
-  inline constexpr auto operator()() -> bool
+  inline constexpr bool operator()(void)
   {
     if constexpr (column_device_view::has_element_accessor<TypeLhs>() and
                   column_device_view::has_element_accessor<TypeRhs>()) {
@@ -79,7 +79,7 @@ struct is_binary_operation_supported {
   }
 
   template <typename TypeOut, typename TypeLhs, typename TypeRhs>
-  inline constexpr auto operator()() -> bool
+  inline constexpr bool operator()(void)
   {
     if constexpr (column_device_view::has_element_accessor<TypeLhs>() and
                   column_device_view::has_element_accessor<TypeRhs>() and

cpp/src/groupby/sort/functors.hpp

@@ -55,7 +55,7 @@ struct store_result_functor {
   /**
    * @brief Check if the groupby keys are presorted
    */
-  [[nodiscard]] bool is_presorted() const { return keys_are_sorted == sorted::YES; }
+  bool is_presorted() const { return keys_are_sorted == sorted::YES; }
 
   /**
    * @brief Get the grouped values

cpp/src/io/avro/avro.cpp

@@ -15,7 +15,7 @@
  */
 
 #include "avro.h"
-#include <cstring>
+#include <string.h>
 #include <unordered_map>
 
 namespace cudf {
@@ -75,7 +75,7 @@ auto container::parse(file_metadata* md, size_t max_num_rows, size_t first_row)
   sig4 |= get_raw<uint8_t>() << 24;
   if (sig4 != avro_magic) { return false; }
   for (;;) {
-    auto num_md_items = static_cast<uint32_t>(get_encoded<int64_t>());
+    uint32_t num_md_items = static_cast<uint32_t>(get_encoded<int64_t>());
     if (num_md_items == 0) { break; }
     for (uint32_t i = 0; i < num_md_items; i++) {
       auto const key   = get_encoded<std::string>();

cpp/src/io/comp/brotli_dict.cpp

@@ -49,7 +49,7 @@ THE SOFTWARE.
 */
 
 #include "brotli_dict.h"
-#include <cstdint>
+#include <stdint.h>
 
 namespace cudf {
 namespace io {
@@ -6528,7 +6528,7 @@ static const brotli_dictionary_s g_dictionary = {
    136, 224, 164, 184, 224, 164, 149, 224, 165, 141, 224, 164, 176, 224, 164, 191, 224, 164, 175,
    224, 164, 164, 224, 164, 190}};
 
-auto get_brotli_dictionary() -> const brotli_dictionary_s* { return &g_dictionary; }
+const brotli_dictionary_s* get_brotli_dictionary(void) { return &g_dictionary; }
 
 }  // namespace io
 }  // namespace cudf

cpp/src/io/comp/cpu_unbz2.cpp

@@ -81,8 +81,8 @@ For more information on these sources, see the manual.
 
 #include "io_uncomp.h"
 #include "unbz2.h"
-#include <cstdio>
-#include <cstdlib>
+#include <stdio.h>
+#include <stdlib.h>
 #include <vector>
 
 namespace cudf {
@@ -111,15 +111,15 @@ namespace io {
 
 #define BZ_MAX_SELECTORS (2 + (900000 / BZ_G_SIZE))
 
-using huff_s = struct {
+typedef struct {
   int32_t minLen;
   int32_t limit[BZ_MAX_CODE_LEN];
   int32_t base[BZ_MAX_CODE_LEN];
   uint16_t perm[BZ_MAX_ALPHA_SIZE];
-};
+} huff_s;
 
 // Decoder state
-using unbz_state_s = struct {
+typedef struct {
   // Input
   const uint8_t* cur;
   const uint8_t* end;
@@ -153,7 +153,7 @@ using unbz_state_s = struct {
   uint8_t len[BZ_MAX_ALPHA_SIZE];
 
   huff_s ht[BZ_N_GROUPS];
-};
+} unbz_state_s;
 
 // return next 32 bits
 static inline auto next32bits(const unbz_state_s* s) -> uint32_t

cpp/src/io/comp/uncomp.cpp

@@ -22,7 +22,7 @@
 
 #include <cuda_runtime.h>
 
-#include <cstring>  // memset
+#include <string.h>  // memset
 
 #include <zlib.h>  // uncompress
 
@@ -196,7 +196,7 @@ auto OpenZipArchive(zip_archive_s* dst, const uint8_t* raw, size_t len) -> bool
     for (ptrdiff_t i = len - sizeof(zip_eocd_s) - 2;
          i + sizeof(zip_eocd_s) + 2 + 0xffff >= len && i >= 0;
          i--) {
-      const auto* eocd = reinterpret_cast<zip_eocd_s const*>(raw + i);
+      const zip_eocd_s* eocd = reinterpret_cast<zip_eocd_s const*>(raw + i);
       if (eocd->sig == 0x06054b50 &&
           eocd->disk_id == eocd->start_disk  // multi-file archives not supported
           && eocd->num_entries == eocd->total_entries &&

cpp/src/io/orc/timezone.cpp

@@ -70,8 +70,8 @@ struct timezone_file {
   std::vector<localtime_type_record_s> ttype;
   std::vector<char> posix_tz_string;
 
-  [[nodiscard]] auto timecnt() const { return header.timecnt; }
-  [[nodiscard]] auto typecnt() const { return header.typecnt; }
+  auto timecnt() const { return header.timecnt; }
+  auto typecnt() const { return header.typecnt; }
 
   // Based on https://tools.ietf.org/id/draft-murchison-tzdist-tzif-00.html
   static constexpr auto leap_second_rec_size(bool is_64bit) noexcept
@@ -222,7 +222,7 @@ class posix_parser {
   /**
    * @brief Returns the next character in the input.
    */
-  [[nodiscard]] auto next_character() const -> char { return *cur; }
+  [[nodiscard]] char next_character() const { return *cur; }
 
  private:
   typename Container::const_iterator cur;