-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin libcudf runtime dependency for cudf / libcudf-kafka nightlies #9847
Pin libcudf runtime dependency for cudf / libcudf-kafka nightlies #9847
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #9847 +/- ##
=================================================
+ Coverage 10.42% 86.13% +75.71%
=================================================
Files 119 139 +20
Lines 20603 22433 +1830
=================================================
+ Hits 2148 19323 +17175
+ Misses 18455 3110 -15345
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should also do this for |
IIRC this was very early on in cudf and the desire at the time was to allow changing the nightly libcudf version underneath cudf to pull in nightly bug fixes in libcudf without necessarily pulling in changes in cudf. It likely isn't relevant anymore now that cudf is a lot more mature. |
Thanks for the clarification @kkraus14 🙂 in that case, think we should be safe to merge this |
Hmm actually I didn't consider the case where the versions match up but the build strings don't; for example, it would still be possible to do something like mamba install cudf=*=cuda_11_py38_g38631a635f_189 libcudf=*=cuda11_gdb9aef8181_190 And end up with a broken cuDF installation (which is exactly what happened in this erroneous image build for dask-sql's gpuCI). Would it be too restrictive to pin nightlies by their git describe tag and number? - libcudf {{ version }} *{{ GIT_DESCRIBE_HASH }}_{{ GIT_DESCRIBE_NUMBER }} |
Hmmm. I think that was attempted before and caused some issues: #7793 |
In that case I'm okay with merging this for now, as it should at least reduce some conda solving issues. I'm interested in what the failures were cc @raydouglass in case you recall - it looks like the pinning was originally meant to solve https://github.com/rapidsai/ops/issues/1490 but it didn't? |
@charlesbluca, for reference, we're currently exploring a lot of improvements to our current build/CI system. One of the things we're looking into is consolidating our recipes, similarly to what's described here (particularly the screenshot below). This would let us build the CPP and Python packages from a single recipe and pin the Python packages to the exact CPP package from the same build. No word on any ETAs yet, but just wanted to let you know that this is something we're looking into. |
This PR has been labeled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We can discuss this more with @jakirkham in the upcoming meeting that I mentioned to you. For now, this is in line with how cuml
does things, so it should be fine.
@gpucibot merge |
@gpucibot merge |
(I deployed some updates that broke the merge bot which is probably why the initial |
Looking at the cudf nightlies on Anaconda, I noticed we aren't pinning the libcudf dependency, only constraining it to the current minor version (i.e.
libcudf >=22.2.0a.211206,<22.3.0a0
); this makes it possible to install mismatched versions of cudf and libcudf nightlies, which can result in a broken cudf installation.This PR pins the libcudf runtime dependency for our cudf nightlies, as well as for libcudf-kafka, which also has a libcudf runtime dependency.