Use pandas to_offset to parse frequency string in date_range
#9843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added
3 - Ready for Review
skirui-source
approved these changes
Dec 9, 2021
bdice
approved these changes
Dec 15, 2021
Co-authored-by: Bradley Dice <[email protected]>
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9843 +/- ##
================================================
- Coverage 10.49% 10.40% -0.09%
================================================
Files 119 119
Lines 20305 20501 +196
================================================
+ Hits 2130 2134 +4
- Misses 18175 18367 +192
Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas uses the following regex to convert freqeuncy strings into offset, which is exposed in public api
pd.tseries.frequencies.to_offset. Currently cudf depends on a custom regex to perform the conversion. We probably shouldn't reinvent the wheels here as it might make it harder to track changes in pandas.