Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ORC writer crash with empty input columns #9831

Merged
merged 5 commits into from
Dec 3, 2021
Merged

Fix ORC writer crash with empty input columns #9831

merged 5 commits into from
Dec 3, 2021

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Dec 2, 2021

Backport of #9808

@vuule vuule added bug Something isn't working ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround cuIO cuIO issue non-breaking Non-breaking change labels Dec 2, 2021
@vuule vuule self-assigned this Dec 2, 2021
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Dec 2, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021 •
edited
Loading

Codecov Report

Merging #9831 (33dc6f3) into branch-21.12 (74ac6ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-21.12    #9831   +/-   ##
=============================================
  Coverage         10.60%   10.60%           
=============================================
  Files               118      118           
  Lines             20081    20081           
=============================================
  Hits               2130     2130           
  Misses            17951    17951

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ac6ed...33dc6f3. Read the comment docs.

@vuule vuule marked this pull request as ready for review December 3, 2021 01:17
@vuule vuule requested review from a team as code owners December 3, 2021 01:17
@vuule vuule requested review from devavret, ttnghia, cwharris and skirui-source and removed request for a team December 3, 2021 01:17
@raydouglass raydouglass merged commit a93d333 into rapidsai:branch-21.12 Dec 3, 2021
@vuule vuule deleted the bug-empty-orc-backport branch January 19, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdbaranec nvdbaranec nvdbaranec approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@ttnghia ttnghia ttnghia approved these changes

@devavret devavret Awaiting requested review from devavret devavret is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vuule vuule

Labels
! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vuule @ttnghia @galipremsagar @nvdbaranec @raydouglass