Enforce boolean ascending
for dask-cudf sort_values
#9814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to pass a list of
ascending
booleans to dask-cudf'ssort_values
, which is not yet supported byquantile_divisions
(which computes divisions for all sort-by columns sorted in ascending order), and can cause undefined behavior.This small PR adds a check that
ascending
is a boolean before computing quantile divisions; note that this check happens after the single-partition case is handled, as cuDF can handle lists ofascending
booleans.