Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load native dependencies when Java ColumnView is loaded #9800

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Nov 30, 2021

The Java ColumnView class has native methods but does not ensure the corresponding native libraries that implement those methods are loaded. This adds a static code block to the ColumnView class to load the native libraries when the ColumnView class is loaded.

@jlowe jlowe added bug Something isn't working Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Nov 30, 2021
@jlowe jlowe self-assigned this Nov 30, 2021
@jlowe jlowe requested a review from a team as a code owner November 30, 2021 18:42
@jlowe
Copy link
Member Author

jlowe commented Nov 30, 2021

rerun tests

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #9800 (e1c2fec) into branch-22.02 (967a333) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9800      +/-   ##
================================================
- Coverage         10.49%   10.18%   -0.31%     
================================================
  Files               119      119              
  Lines             20305    20944     +639     
================================================
+ Hits               2130     2133       +3     
- Misses            18175    18811     +636     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/csv.py 96.00% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27b7190...e1c2fec. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Nov 30, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 554ac81 into rapidsai:branch-22.02 Nov 30, 2021
@jlowe jlowe deleted the jni-columnview-loaddeps branch November 30, 2021 21:51
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants