Refactor host device macros #9797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
vuule
reviewed
Nov 30, 2021
…_device_macros # Conflicts: # cpp/tests/iterator/optional_iterator_test_numeric.cu
vyasr
force-pushed
the
refactor/host_device_macros
branch
from
b9959d4
to
3192065
Compare
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9797 +/- ##
================================================
- Coverage 10.49% 10.42% -0.07%
================================================
Files 119 119
Lines 20305 20475 +170
================================================
+ Hits 2130 2134 +4
- Misses 18175 18341 +166
Continue to review full report at Codecov.
|
vuule
approved these changes
Dec 9, 2021
jrhemstad
approved these changes
Dec 13, 2021
harrism
requested changes
Dec 14, 2021
|
@harrism @jrhemstad this should be good to go now if everyone is satisfied with the outcome of the discussion. The only macro left is |
bdice
approved these changes
Jan 6, 2022
harrism
approved these changes
Jan 10, 2022
|
@gpucibot merge |
|
FYI, merging this broke the cuSpatial build. |
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Jan 11, 2022
One file in libcuspatial used `CUDA_HOST_DEVICE` from cudf/types.hpp instead of just `__device__ inline`, which is all it needed. rapidsai/cudf#9797 changed the name of the macro, which broke the build. This trivial PR fixes it and removes that particular unnecessary dependency. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Paul Taylor (https://github.com/trxcllnt) - Christopher Harris (https://github.com/cwharris) URL: #475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #9530 to standardize the names of the macros used for the
__host__ __device__attributes. Aliases for__device__and combinations with inlining have been removed, and the only remaining macro isCUDF_HOST_DEVICEwhich is__host__ __device__in device code and empty in host code. See #9530 (comment) for more discussion.