Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtype-argument bug in dask_cudf read_csv #9796

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

rjzamora
Copy link
Member

Closes #9719

dask_cudf.read_csv currently fails when both usecols and dtype are specified. This PR is a simple fix. In the near future, the _internal_read_csv implementation should also be modified to produce a Blockwise HLG Layer, but I will leave that for a separate PR.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 29, 2021
@rjzamora rjzamora self-assigned this Nov 29, 2021
@rjzamora rjzamora added 2 - In Progress Currently a work in progress bug Something isn't working dask Dask issue non-breaking Non-breaking change labels Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #9796 (a58be3f) into branch-22.02 (967a333) will decrease coverage by 0.00%.
The diff coverage is 12.35%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9796      +/-   ##
================================================
- Coverage         10.49%   10.48%   -0.01%     
================================================
  Files               119      119              
  Lines             20305    20344      +39     
================================================
+ Hits               2130     2133       +3     
- Misses            18175    18211      +36     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/csv.py 96.00% <100.00%> (+0.10%) ⬆️
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83adc4b...a58be3f. Read the comment docs.

@rjzamora rjzamora marked this pull request as ready for review November 30, 2021 02:05
@rjzamora rjzamora requested a review from a team as a code owner November 30, 2021 02:05
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 30, 2021
@rjzamora
Copy link
Member Author

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 30, 2021
@rjzamora
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dca8a0a into rapidsai:branch-22.02 Nov 30, 2021
@rjzamora rjzamora deleted the csv-dtype-fix branch November 30, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]dask_cudf: read_csv seems to compute only first partition
2 participants