Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jit code of binary operation #9794

Merged
merged 13 commits into from
Nov 30, 2021
Merged

Remove jit code of binary operation #9794

merged 13 commits into from
Nov 30, 2021

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Nov 29, 2021 •
edited
Loading

Rebased version of #9777 for 21.12

@robertmaynard robertmaynard added bug Something isn't working 5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change labels Nov 29, 2021
@robertmaynard robertmaynard requested review from a team as code owners November 29, 2021 20:40
@robertmaynard robertmaynard requested review from cwharris, jrhemstad and charlesbluca and removed request for a team November 29, 2021 20:40
@github-actions github-actions bot added CMake CMake build issue Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Nov 29, 2021
@robertmaynard robertmaynard mentioned this pull request Nov 29, 2021
Closed
@robertmaynard robertmaynard requested a review from bdice November 29, 2021 20:43
@robertmaynard
Copy link
Contributor Author

rerun tests

bdice
bdice approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving same changes from #9777.

@ajschmidt8 ajschmidt8 mentioned this pull request Nov 29, 2021
Closed
@ajschmidt8
Copy link
Member

rerun tests

@codecov
Copy link

codecov bot commented Nov 29, 2021 •
edited
Loading

Codecov Report

Merging #9794 (dc6976a) into branch-21.12 (8e2ac44) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head dc6976a differs from pull request most recent head a3ba687. Consider uploading reports for the commit a3ba687 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9794      +/-   ##
================================================
- Coverage         10.61%   10.60%   -0.01%     
================================================
  Files               118      118              
  Lines             20072    20081       +9     
================================================
  Hits               2130     2130              
- Misses            17942    17951       +9
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2ac44...a3ba687. Read the comment docs.

@jjacobelli jjacobelli merged commit 2c6f919 into rapidsai:branch-21.12 Nov 30, 2021
@robertmaynard robertmaynard deleted the Remove_jit_code_of_binary_operation branch November 30, 2021 13:56
@mythrocks mythrocks mentioned this pull request Nov 30, 2021
Merged
@jrhemstad jrhemstad mentioned this pull request Feb 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@shwina shwina shwina approved these changes

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@robertmaynard @ajschmidt8 @shwina @bdice @ttnghia @jjacobelli @karthikeyann