Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused masked udf cython/c++ code #9792

Merged

Conversation

brandon-b-miller
Copy link
Contributor

This PR removes the c++ side of the original masked UDF code introduced in #8213. These kernels had some limitations and are now superseded by the numba-generated versions we moved to in #9174. As far as I can tell, cuDF python was the only thing consuming this API for the short time it has existed. However I am marking this breaking just in case.

@brandon-b-miller brandon-b-miller added libcudf Affects libcudf (C++/CUDA) code. Cython improvement Improvement / enhancement to an existing function labels Nov 29, 2021
@brandon-b-miller brandon-b-miller requested review from a team as code owners November 29, 2021 19:30
@github-actions github-actions bot added CMake CMake build issue Python Affects Python cuDF API. labels Nov 29, 2021
@brandon-b-miller brandon-b-miller added the breaking Breaking change label Nov 29, 2021
@vyasr
Copy link
Contributor

vyasr commented Nov 29, 2021

@brandon-b-miller if you're using pre-commit locally you should be able to install and run the cmake-format check locally yourself with the usual pre-commit commands. If you're not, then make sure cmake-format is installed to your local environment and and invoke the cpp/scripts/run-cmake-format.sh script directly.

Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Brandon

@brandon-b-miller
Copy link
Contributor Author

@brandon-b-miller if you're using pre-commit locally you should be able to install and run the cmake-format check locally yourself with the usual pre-commit commands. If you're not, then make sure cmake-format is installed to your local environment and and invoke the cpp/scripts/run-cmake-format.sh script directly.

Thanks @vyasr this worked great!

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #9792 (7866534) into branch-22.02 (967a333) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 7866534 differs from pull request most recent head a83da5b. Consider uploading reports for the commit a83da5b to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9792      +/-   ##
================================================
- Coverage         10.49%   10.47%   -0.02%     
================================================
  Files               119      119              
  Lines             20305    20341      +36     
================================================
  Hits               2130     2130              
- Misses            18175    18211      +36     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1811b5...a83da5b. Read the comment docs.

@brandon-b-miller brandon-b-miller added the 3 - Ready for Review Ready for review by team label Nov 30, 2021
@brandon-b-miller brandon-b-miller added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 1, 2021
@brandon-b-miller
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 11c3dfe into rapidsai:branch-22.02 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants