-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused masked udf cython/c++ code #9792
Remove unused masked udf cython/c++ code #9792
Conversation
@brandon-b-miller if you're using pre-commit locally you should be able to install and run the cmake-format check locally yourself with the usual pre-commit commands. If you're not, then make sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this Brandon
Thanks @vyasr this worked great! |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9792 +/- ##
================================================
- Coverage 10.49% 10.47% -0.02%
================================================
Files 119 119
Lines 20305 20341 +36
================================================
Hits 2130 2130
- Misses 18175 18211 +36
Continue to review full report at Codecov.
|
@gpucibot merge |
This PR removes the c++ side of the original masked UDF code introduced in #8213. These kernels had some limitations and are now superseded by the numba-generated versions we moved to in #9174. As far as I can tell, cuDF python was the only thing consuming this API for the short time it has existed. However I am marking this breaking just in case.