Fix memory error due to lambda return type deduction limitation #9778
Conversation
Fixes #9703 add __host__ for nvcc return type deduction to work. replaced `auto` (generic lambda) with size_type.
karthikeyann
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9778 +/- ##
================================================
- Coverage 10.49% 10.47% -0.02%
================================================
Files 119 119
Lines 20305 20368 +63
================================================
+ Hits 2130 2133 +3
- Misses 18175 18235 +60
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Can you add a gtest equivalent to this?#9703 (comment)
This way, the test will fail if someone inadvertently removes the __host__ in the future.
replace host device lambda with device functor due to device lambda return type deduction limitation
karthikeyann
changed the title
|
rerun tests |
There was a problem hiding this comment.
Could you add the following gtest to the rank_test.cpp so this will fail if the functor ever gets converted back to a lambda?
struct RankLarge : public BaseFixture {
};
TEST_F(RankLarge, test_large)
{
auto iter = thrust::counting_iterator<int64_t>(0);
fixed_width_column_wrapper<int64_t> col1(iter, iter + 10558);
auto result =
cudf::rank(col1, rank_method::AVERAGE, {}, null_policy::EXCLUDE, null_order::AFTER, false);
fixed_width_column_wrapper<double, int> expected(iter + 1, iter + 10559);
CUDF_TEST_EXPECT_COLUMNS_EQUAL(result->view(), expected);
}
I was not able to get 1558 to fail on my GPU but 10558 did.
I verified your fix here works for my GPU with this.
|
Thank you @davidwendt |
Co-authored-by: David Wendt <[email protected]>
|
@gpucibot merge |
Fixes #9703
replace device lambda with device functor with return type. (due to 14. extended-lambda-restrictions )
add__host__to lambda for nvcc return type deduction to work properly.replacedauto(generic lambda) withsize_type.fixes shared memory write error caused in #9703